ahmed-bakr1988/SaaS-PDF
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: clean up health check and task access logic by removing unused code

Browse Source
This commit is contained in:
Your Name
2026-03-21 09:10:18 +02:00
parent f347022924
commit e1585216e6
4 changed files with 4 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
backend/app/services/account_service.py
View File

@@ -678,23 +678,6 @@ def has_task_access(user_id: int, source: str, task_id: str) -> bool:
return row is not None
def has_download_access(user_id: int, file_task_id: str) -> bool:
"""Return whether one user owns a file_history entry whose download_url contains the given file task id."""
pattern = f"/api/download/{file_task_id}/"
with _connect() as conn:
row = conn.execute(
"""
SELECT 1
FROM file_history
WHERE user_id = ? AND download_url LIKE ?
LIMIT 1
""",
(user_id, f"%{pattern}%"),
).fetchone()
return row is not None
# ---------------------------------------------------------------------------
# Password reset tokens
# ---------------------------------------------------------------------------

11
backend/app/services/policy_service.py
View File

@@ -8,7 +8,6 @@ from app.services.account_service import (
get_api_key_actor,
get_user_by_id,
get_current_period_month,
has_download_access,
has_task_access,
normalize_plan,
record_usage_event,
@@ -228,13 +227,8 @@ def build_task_tracking_kwargs(actor: ActorContext) -> dict:
def assert_api_task_access(actor: ActorContext, task_id: str):
"""Ensure one API actor can poll one task id."""
if actor.user_id is None:
if actor.user_id is None or not has_task_access(actor.user_id, "api", task_id):
raise PolicyError("Task not found.", 404)
if has_task_access(actor.user_id, "api", task_id):
return
if has_download_access(actor.user_id, task_id):
return
raise PolicyError("Task not found.", 404)
def assert_web_task_access(actor: ActorContext, task_id: str):
@@ -242,9 +236,6 @@ def assert_web_task_access(actor: ActorContext, task_id: str):
if actor.user_id is not None and has_task_access(actor.user_id, "web", task_id):
return
if actor.user_id is not None and has_download_access(actor.user_id, task_id):
return
if has_session_task_access(task_id):
return